Corncob Posted October 1, 2016 Share Posted October 1, 2016 package com.rs.game.player.dialogues.impl; import com.rs.game.WorldTile; import com.rs.game.item.Item; import com.rs.game.player.content.DonatorZone; import com.rs.game.player.content.EconomyManager; import com.rs.game.player.content.Magic; import com.rs.game.player.dialogues.Dialogue; public class JmodPotato extends Dialogue { @Override public void start() { sendOptionsDialogue("Choose an Admin option:", "God", "Account", "Oracle", "StaffZone", "Next page"); } @Override public void run(int interfaceId, int componentId) { if (stage == -1) { if (componentId == OPTION_1) { player.setHitpoints(1000000); end(); } else if (componentId == OPTION_2) { sendOptionsDialogue("Choose an Admin option:", "Setups", "Empty inventory", "Max stats", "Reset stats", "Next page"); stage = 2; } else if (componentId == OPTION_3) { player.getDialogueManager().startDialogue("EconomyManager"); EconomyManager.processManagerNpcClick(player, 13930); } else if (componentId == OPTION_4) { Magic.sendNormalTeleportSpell(player, 1, 0, new WorldTile(4192, 6304, 0)); end(); } else if (componentId == OPTION_5) { sendOptionsDialogue("Choose an Admin option:", "DonatorZone", "Extreme DonatorZone", "Back"); stage = 1; } } else if (stage == 1) { if (componentId == OPTION_1) { DonatorZone.enterDonatorzone(player); end(); } else if (componentId == OPTION_2) { Magic.sendNormalTeleportSpell(player, 1, 0, new WorldTile(5632, 4109, 0)); end(); } else if (componentId == OPTION_3) { stage = -1; } } else if (stage == 2) { if (componentId == OPTION_1) { sendOptionsDialogue("Choose a style:", "Dual-Wield", "2 Handed", "Reset"); stage = 3; } else if (componentId == OPTION_2) { player.getInventory().reset(); player.getInventory().addItem(5733, 1); end(); } else if (componentId == OPTION_3){ for (int skill = 0; skill < 26; skill++) player.getSkills().addXp(skill, 200000000); end(); } else if (componentId == OPTION_4) { for (int skill = 0; skill < 26; skill++) { player.getSkills().setXp(skill, 0); player.getSkills().set(skill, 1); end(); } } else if (componentId == OPTION_5) { sendOptionsDialogue("Choose an Admin option:", "Reset Account", "Item"); stage = 6; } } else if (stage == 3) { if (componentId == OPTION_1) { sendOptionsDialogue("Choose a Duel-Wield style:", "Melee", "Ranged", "Mage"); stage = 4; } else if (componentId == OPTION_2) { sendOptionsDialogue("Choose a 2 Handed style:", "Melee", "Ranged", "Mage"); stage = 5; } else if (componentId == OPTION_3) { player.getEquipment().reset(); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getAppearence().generateAppearenceData(); end(); } } else if (stage == 4) { if (componentId == OPTION_1) { player.getEquipment().reset(); player.getEquipment().getItems().set(0, new Item(30005, 1)); player.getEquipment().getItems().set(1, new Item(32152, 1)); player.getEquipment().getItems().set(2, new Item(31875, 1)); player.getEquipment().getItems().set(3, new Item(26579, 1)); player.getEquipment().getItems().set(4, new Item(30008, 1)); player.getEquipment().getItems().set(5, new Item(26599, 1)); player.getEquipment().getItems().set(7, new Item(30011, 1)); player.getEquipment().getItems().set(9, new Item(30213, 1)); player.getEquipment().getItems().set(10, new Item(21787, 1)); player.getEquipment().getItems().set(12, new Item(31869, 1)); player.getEquipment().getItems().set(14, new Item(22298, 1)); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getAppearence().generateAppearenceData(); end(); } else if (componentId == OPTION_2) { player.getEquipment().reset(); player.getEquipment().getItems().set(0, new Item(29854, 1)); player.getEquipment().getItems().set(1, new Item(32152, 1)); player.getEquipment().getItems().set(2, new Item(31875, 1)); player.getEquipment().getItems().set(3, new Item(28437, 1)); player.getEquipment().getItems().set(4, new Item(29857, 1)); player.getEquipment().getItems().set(5, new Item(28441, 1)); player.getEquipment().getItems().set(7, new Item(29860, 1)); player.getEquipment().getItems().set(9, new Item(31203, 1)); player.getEquipment().getItems().set(10, new Item(21790, 1)); player.getEquipment().getItems().set(12, new Item(31869, 1)); player.getEquipment().getItems().set(13, new Item(28465, 1000)); player.getEquipment().getItems().set(14, new Item(22298, 1)); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getAppearence().generateAppearenceData(); end(); } else if (componentId == OPTION_3) { player.getEquipment().reset(); player.getEquipment().getItems().set(0, new Item(28608, 1)); player.getEquipment().getItems().set(1, new Item(32152, 1)); player.getEquipment().getItems().set(2, new Item(31875, 1)); player.getEquipment().getItems().set(3, new Item(28617, 1)); player.getEquipment().getItems().set(4, new Item(28611, 1)); player.getEquipment().getItems().set(5, new Item(28621, 1)); player.getEquipment().getItems().set(7, new Item(28614, 1)); player.getEquipment().getItems().set(9, new Item(31189, 1)); player.getEquipment().getItems().set(10, new Item(21793, 1)); player.getEquipment().getItems().set(12, new Item(31869, 1)); player.getEquipment().getItems().set(14, new Item(22298, 1)); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getInventory().addItem(565, 3000); player.getInventory().addItem(554, 7000); player.getInventory().addItem(555, 7000); player.getAppearence().generateAppearenceData(); end(); } } else if (stage == 5) { if (componentId == OPTION_1) { player.getEquipment().reset(); player.getEquipment().getItems().set(0, new Item(30005, 1)); player.getEquipment().getItems().set(1, new Item(32152, 1)); player.getEquipment().getItems().set(2, new Item(31875, 1)); player.getEquipment().getItems().set(3, new Item(31725, 1)); player.getEquipment().getItems().set(4, new Item(30008, 1)); player.getEquipment().getItems().set(7, new Item(30011, 1)); player.getEquipment().getItems().set(9, new Item(30213, 1)); player.getEquipment().getItems().set(10, new Item(21787, 1)); player.getEquipment().getItems().set(12, new Item(31869, 1)); player.getEquipment().getItems().set(14, new Item(22298, 1)); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getAppearence().generateAppearenceData(); end(); } else if (componentId == OPTION_2) { player.getEquipment().reset(); player.getEquipment().getItems().set(0, new Item(29854, 1)); player.getEquipment().getItems().set(1, new Item(32152, 1)); player.getEquipment().getItems().set(2, new Item(31875, 1)); player.getEquipment().getItems().set(3, new Item(31733, 1)); player.getEquipment().getItems().set(4, new Item(29857, 1)); player.getEquipment().getItems().set(7, new Item(29860, 1)); player.getEquipment().getItems().set(9, new Item(31203, 1)); player.getEquipment().getItems().set(10, new Item(21790, 1)); player.getEquipment().getItems().set(12, new Item(31869, 1)); player.getEquipment().getItems().set(13, new Item(31737, 1000)); player.getEquipment().getItems().set(14, new Item(22298, 1)); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getAppearence().generateAppearenceData(); end(); } else if (componentId == OPTION_3) { player.getEquipment().reset(); player.getEquipment().getItems().set(0, new Item(28608, 1)); player.getEquipment().getItems().set(1, new Item(32152, 1)); player.getEquipment().getItems().set(2, new Item(31875, 1)); player.getEquipment().getItems().set(3, new Item(31729, 1)); player.getEquipment().getItems().set(4, new Item(28611, 1)); player.getEquipment().getItems().set(7, new Item(28614, 1)); player.getEquipment().getItems().set(9, new Item(31189, 1)); player.getEquipment().getItems().set(10, new Item(21793, 1)); player.getEquipment().getItems().set(12, new Item(31869, 1)); player.getEquipment().getItems().set(14, new Item(22298, 1)); player.getEquipment().refresh(0); player.getEquipment().refresh(1); player.getEquipment().refresh(2); player.getEquipment().refresh(3); player.getEquipment().refresh(4); player.getEquipment().refresh(5); player.getEquipment().refresh(7); player.getEquipment().refresh(9); player.getEquipment().refresh(10); player.getEquipment().refresh(12); player.getEquipment().refresh(13); player.getEquipment().refresh(14); player.getInventory().addItem(565, 3000); player.getInventory().addItem(554, 7000); player.getInventory().addItem(555, 7000); player.getAppearence().generateAppearenceData(); end(); } } else if (stage == 6) { if (componentId == OPTION_1) { player.completeReset(); end(); } else if (componentId == OPTION_2) { player.getTemporaryAttributtes().put("itemid", Boolean.TRUE); player.getPackets().sendInputIntegerScript("Enter the id of the item you want:"); end(); } } } @Override public void finish() { // TODO Auto-generated method stub } } Link to comment Share on other sites More sharing options...
Hope Posted October 1, 2016 Share Posted October 1, 2016 Please build a better refreshing system in your equipment class: player.getEquipment().refresh(); /** * Called once to refresh equipment **/ public void refresh() { for (int i = 0; i < TOTAL_SLOTS; i++) { refresh(i); } } Link to comment Share on other sites More sharing options...
wot Posted October 1, 2016 Share Posted October 1, 2016 3 hours ago, Hope said: Please build a better refreshing system in your equipment class: player.getEquipment().refresh(); /** * Called once to refresh equipment **/ public void refresh() { for (int i = 0; i < TOTAL_SLOTS; i++) { refresh(i); } } public void refresh(int... slots) { if (slots != null) { player.getPackets().sendUpdateItems(94, items, slots); player.getCombatDefinitions().checkAttackStyle(); } player.getCombatDefinitions().refreshBonuses(); refreshConfigs(slots == null); } This is already in matrix bro, so you could just do refresh(IntStream.rangeClosed(0, 14).toArray()); Link to comment Share on other sites More sharing options...
Hope Posted October 5, 2016 Share Posted October 5, 2016 On 10/1/2016 at 11:32 AM, wot said: public void refresh(int... slots) { if (slots != null) { player.getPackets().sendUpdateItems(94, items, slots); player.getCombatDefinitions().checkAttackStyle(); } player.getCombatDefinitions().refreshBonuses(); refreshConfigs(slots == null); } This is already in matrix bro, so you could just do refresh(IntStream.rangeClosed(0, 14).toArray()); I literally have no clue what is in matrix and what isn't. I typed that up as an example (pseudo-code ish if you will). Link to comment Share on other sites More sharing options...
Bevypoo Posted October 15, 2016 Share Posted October 15, 2016 holy fuck so bad Link to comment Share on other sites More sharing options...
Gemu Posted October 15, 2016 Share Posted October 15, 2016 3 hours ago, Bevypoo said: holy fuck so bad Instead of that, tell us in which way the user would be able to make improvements on this. Link to comment Share on other sites More sharing options...
kaos Posted November 18, 2016 Share Posted November 18, 2016 Perhaps separating them into methods and possibly using a switch might make it look a little cleaner, that is one hell of a block of code Link to comment Share on other sites More sharing options...
Eldritch Posted November 18, 2016 Share Posted November 18, 2016 33 minutes ago, kaos said: Perhaps separating them into methods and possibly using a switch might make it look a little cleaner, that is one hell of a block of code It's a dialogue. Dialogues generally tend to get messy and long (Not saying they have to, but most of them will). He could however shorten the code by at least three times, by doing: a) for (int i = 0; i < 14; i++) player.getEquipment().refresh(i); b) Making a container (For example an array, or a hashmap if you need to list down more than one attribute) for the items, so instead of writing each and every single one of them out you could also loop them the same way c) Using switches - This isn't an issue really, however it'd slightly shorten and clean the code up a bit more. If all these three would be optimized to the fullest, your code would be at least three times shorter lines length-wise. I know this is an ancient post, just figured I'd increase my post count Link to comment Share on other sites More sharing options...
Recommended Posts